Chore: improve pop up block behaviour#256
Open
roshan-gorasia-cko wants to merge 1 commit intomasterfrom
Open
Conversation
roshan-gorasia-cko
force-pushed
the
chore/improve-pop-up-block-behaviour
branch
from
570aa71 to
72484c8
Compare
roshan-gorasia-cko
changed the title
roshan-gorasia-cko
force-pushed
the
chore/improve-pop-up-block-behaviour
branch
from
dca5e5c to
fe91bc4
Compare
roshan-gorasia-cko
requested review from
jakubjasinsky and
tomasz-pazdziurek-cko
| private showPopupBlockedFallbackOverlay() { | ||
| // Full-screen backdrop with centered content card | ||
| const overlay = document.createElement('div') | ||
| overlay.style.cssText = 'position:fixed;top:0;left:0;right:0;bottom:0;z-index:2147483647;background:rgba(0,0,0,0.5);display:flex;align-items:center;justify-content:center;padding:16px;box-sizing:border-box;' |
Contributor
There was a problem hiding this comment.
Makes me wonder how we managed to calculate this z-index 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When conducting headless mode via the new APM flow, there is a chance that browsers may block the redirect (as we've seen in some Safari instances).
On this flow, we can provide a "fallback" UI where the customer is directed to press "pay" so the redirect occurs following a customer interaction.
Solution
When we detect a browser block, we emit an event to state this and also give the option to show a fallback UI to the customer so they continue the payment.
Demo
https://processout.slack.com/archives/C085M5SPTUJ/p1776085378944209?thread_ts=1774624241.259649&cid=C085M5SPTUJ
Checklist
yarn bump-versionNotes
Jira Issue